clarify KernelDensity.score{,_samples} docstrings #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the intention was to allow ndim>2, but the code doesn't actually allow it present. Merging. |
larsmans
added a commit
that referenced
this pull request
Sep 25, 2014
DOC clarify KernelDensity.score{,_samples} docstrings
IssamLaradji
pushed a commit
to IssamLaradji/scikit-learn
that referenced
this pull request
Oct 13, 2014
DOC clarify KernelDensity.score{,_samples} docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs for
KernelDensity'sscoreandscore_samplesmethods are confusingly worded, andscore's return shape is wrong. This clarifies them, I think.