[MRG+2] FIX make StandardScaler & scale more numerically stable #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect common numerical stability problems in the standardization routines and try simple mitigation strategies while alos issuing a warning.
|
Alright so the numerical stability issues seems to depend on either the version of numpy or Python... We will have to relax the tests... |
|
|
1 similar comment
|
|
|
|
amueller
added a commit
that referenced
this pull request
Mar 23, 2015
[MRG+2] FIX make StandardScaler & scale more numerically stable
|
I did the backport to 0.16.X. |
|
Sorry for the slow reply. Yes this is perfect, thanks for your fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and fixed version of #3747. I will merge if travis is still green.