Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] FIX n_jobs slicing bug in dict learning #4751

Merged
merged 1 commit into from May 22, 2015

Conversation

amueller
Copy link
Member

Also add input validation to gen_even_slices.
Fixes #4746.

@agramfort
Copy link
Member

+1 for merge

@agramfort agramfort changed the title [MRG] FIX n_jobs slicing bug in dict learning [MRG+1] FIX n_jobs slicing bug in dict learning May 21, 2015
@amueller amueller added the Bug label May 21, 2015
@ogrisel
Copy link
Member

ogrisel commented May 22, 2015

LGTM, +1 as well. Merging.

ogrisel added a commit that referenced this pull request May 22, 2015
[MRG+1] FIX n_jobs slicing bug in dict learning
@ogrisel ogrisel merged commit 0ee4d97 into scikit-learn:master May 22, 2015
@amueller amueller deleted the dict_learning_n_jobs_bug branch May 19, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dictionary learning is slower and fail with n_jobs > 1
3 participants