Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] DOC Add LabelKFold in _BaseKFold's docstring #6344

Merged
merged 1 commit into from Aug 10, 2016

Conversation

@yenchenlin
Copy link
Contributor

@yenchenlin yenchenlin commented Feb 12, 2016

Since _BaseKFold is also the base class of LabelKFold,
I think LabelKFold should also appeared _BaseKFold's docstring.

@yenchenlin yenchenlin changed the title Add LabelKFold in _BaseKFold's docstring [MRG] DOC Add LabelKFold in _BaseKFold's docstring Feb 13, 2016
@@ -257,7 +257,7 @@ def get_n_splits(self, X, y=None, labels=None):


class _BaseKFold(with_metaclass(ABCMeta, BaseCrossValidator)):
"""Base class for KFold and StratifiedKFold"""
"""Base class for KFold, LabelKFold and StratifiedKFold"""

This comment has been minimized.

@nelson-liu

nelson-liu Feb 24, 2016
Contributor

should have a comma after LabelKFold (KFold, LabelKFold and StratifiedKFold -> KFold, LabelKFold, and StratifiedKFold)

This comment has been minimized.

@yenchenlin

yenchenlin Feb 24, 2016
Author Contributor

Thanks for pointing out the mistake.

@nelson-liu
Copy link
Contributor

@nelson-liu nelson-liu commented Feb 24, 2016

lgtm besides the comma issue.

@yenchenlin yenchenlin force-pushed the yenchenlin:fix-doc branch from dbaa7c7 to 2fa7655 Feb 24, 2016
@yenchenlin yenchenlin force-pushed the yenchenlin:fix-doc branch from 2fa7655 to 09470bc Aug 10, 2016
@yenchenlin
Copy link
Contributor Author

@yenchenlin yenchenlin commented Aug 10, 2016

ping @jnothman , this one is trivial!

@jnothman jnothman merged commit f50790c into scikit-learn:master Aug 10, 2016
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
TomDLT added a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.