[MRG] DOC Add LabelKFold in _BaseKFold's docstring #6344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenchenlin
changed the title
| @@ -257,7 +257,7 @@ def get_n_splits(self, X, y=None, labels=None): | |||
|
|
|||
|
|
|||
| class _BaseKFold(with_metaclass(ABCMeta, BaseCrossValidator)): | |||
| """Base class for KFold and StratifiedKFold""" | |||
| """Base class for KFold, LabelKFold and StratifiedKFold""" | |||
There was a problem hiding this comment.
should have a comma after LabelKFold (KFold, LabelKFold and StratifiedKFold -> KFold, LabelKFold, and StratifiedKFold)
There was a problem hiding this comment.
Thanks for pointing out the mistake.
|
lgtm besides the comma issue. |
|
ping @jnothman , this one is trivial! |
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since _BaseKFold is also the base class of LabelKFold,
I think LabelKFold should also appeared _BaseKFold's docstring.