[MRG] DOC Add LabelKFold in _BaseKFold's docstring #6344

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
3 participants
@yenchenlin
Contributor

yenchenlin commented Feb 12, 2016

Since _BaseKFold is also the base class of LabelKFold,
I think LabelKFold should also appeared _BaseKFold's docstring.

@yenchenlin yenchenlin changed the title from Add LabelKFold in _BaseKFold's docstring to [MRG] DOC Add LabelKFold in _BaseKFold's docstring Feb 13, 2016

sklearn/model_selection/_split.py
@@ -257,7 +257,7 @@ def get_n_splits(self, X, y=None, labels=None):
class _BaseKFold(with_metaclass(ABCMeta, BaseCrossValidator)):
- """Base class for KFold and StratifiedKFold"""
+ """Base class for KFold, LabelKFold and StratifiedKFold"""

This comment has been minimized.

@nelson-liu

nelson-liu Feb 24, 2016

Contributor

should have a comma after LabelKFold (KFold, LabelKFold and StratifiedKFold -> KFold, LabelKFold, and StratifiedKFold)

@nelson-liu

nelson-liu Feb 24, 2016

Contributor

should have a comma after LabelKFold (KFold, LabelKFold and StratifiedKFold -> KFold, LabelKFold, and StratifiedKFold)

This comment has been minimized.

@yenchenlin

yenchenlin Feb 24, 2016

Contributor

Thanks for pointing out the mistake.

@yenchenlin

yenchenlin Feb 24, 2016

Contributor

Thanks for pointing out the mistake.

@nelson-liu

This comment has been minimized.

Show comment
Hide comment
@nelson-liu

nelson-liu Feb 24, 2016

Contributor

lgtm besides the comma issue.

Contributor

nelson-liu commented Feb 24, 2016

lgtm besides the comma issue.

@yenchenlin

This comment has been minimized.

Show comment
Hide comment
@yenchenlin

yenchenlin Aug 10, 2016

Contributor

ping @jnothman , this one is trivial!

Contributor

yenchenlin commented Aug 10, 2016

ping @jnothman , this one is trivial!

@jnothman jnothman merged commit f50790c into scikit-learn:master Aug 10, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

TomDLT added a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment