[MRG+1] Add test for voting classifier‘s init errors #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| eclf = VotingClassifier(estimators=[('lr', clf)], weights=[1, 2]) | ||
| msg = ('Number of classifiers and weights must be equal' | ||
| '; got %d weights, %d estimators' |
There was a problem hiding this comment.
You could just hardcode this? (got 2 weights, 1 estimators)
yenchenlin
force-pushed
the
add-test-for-vote-classifier
branch
from
0961b39
to
e2e773d
Compare
|
Thanks @rvraghav93 ! |
|
Thanks! |
yenchenlin
changed the title
MechCoder
changed the title
|
lgtm |
|
Merging, thanks @yenchenlin1994 |
TomDLT
added a commit
that referenced
this pull request
Feb 29, 2016
…fier [MRG+1] Add test for voting classifier‘s init errors
|
@TomDLT thanks for always helping me a lot! 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added tests for voting classifier to test different errors it will raise when invalid arguments are passed into
__init__andfitis called.Coverage increased (+0.005%) 😄