Add test for local linear embedding #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenchenlin
force-pushed
the
add-test-for-local-linear-embedding
branch
from
0db27ff
to
8877ffe
Compare
| # Test the error raised when parameter passed to lle is invalid | ||
| def test_lle_init_parameters(): | ||
| rng = np.random.RandomState(0) | ||
| X = np.array(list(product(np.arange(18), repeat=2))) |
There was a problem hiding this comment.
You can probably have a simpler X for testing parameters checking
|
Thanks for the contribution! I agreed with @TomDLT's comments that the tests should be simplified after that +1 for merge. |
yenchenlin
force-pushed
the
add-test-for-local-linear-embedding
branch
from
8877ffe
to
d963b2f
Compare
|
Looks good to me. Thanks! |
jakevdp
added a commit
that referenced
this pull request
Feb 18, 2016
…r-embedding Add test for local linear embedding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the errors raised when parameter passed to LLE is invalid.