[MRG] Make GradientBoostingClassifier error message more informative (fixes 6433) #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenchenlin
changed the title
yenchenlin
force-pushed
the
fix-6433
branch
3 times, most recently
from
b884606
to
3f78f9e
Compare
yenchenlin
changed the title
|
I'm sure you will be able to think of a better way to check this (at this stage). |
|
@yenchenlin are you still working on this? |
|
@amueller sorry for the late reply, yes! @MechCoder I think the error message is too verbose, but I still consider it as the fittest place to check this error. Also, maybe variables |
|
This should probably go in the gradient boosting estimator base class.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the error message to make it become more useful.
Can @ogrisel please have a look?
(Oh and it seems CI has some issue)
Fixes #6433