Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] added variation_stop parameter to multylayer perceptron #6518

Closed
wants to merge 4 commits into from

Conversation

usopp
Copy link

@usopp usopp commented Mar 10, 2016

To the issue #6512
As described in book of Simon Haykin "Neural Networks - A Comprehensive Foundation", pp. 237-240, we should find an early stopping point if we use a validation set. But curve of a score on validation set may have it's local minimums and we will end falling in them if we make only 2 iteration after it before stopping. So i added count of iterations made before stop after best score as a parameter. Got an improvemen on MNIST in a few percent with 50 iterations.

@usopp usopp changed the title [MRG] added variation_stop parameter [MRG] added variation_stop parameter to multylayer perceptron Mar 10, 2016
Copy link
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the doctest failure?

Count of interations to attempt before stopping if score
is not improving on the train set or on the validation fraction
if early_stopping is True.
Shold be 2 or more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*should

Count of interations to attempt before stopping if score
is not improving on the train set or on the validation fraction
if early_stopping is True.
Shold be 2 or more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should

@@ -1152,6 +1163,12 @@ class MLPRegressor(BaseMultilayerPerceptron, RegressorMixin):
early stopping. Must be between 0 and 1.
Only used if early_stopping is True

variation_stop : int, optional, default 2
Count of interations to attempt before stopping if score
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iterations

@usopp
Copy link
Author

usopp commented Nov 24, 2016

@amueller Done

@jnothman
Copy link
Member

A test to ensure:

  • that this can make a difference
  • that the number of iterations is greater for a greater value

would be useful.

@jnothman
Copy link
Member

I think #9457 makes this redundant.

@jnothman jnothman closed this Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants