Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bad coef_, intercept_ when interpreting discrete naive bayes as linear model #7253

Closed
wants to merge 1 commit into from
Closed

fix bad coef_, intercept_ when interpreting discrete naive bayes as linear model #7253

wants to merge 1 commit into from

Conversation

luoq
Copy link

@luoq luoq commented Aug 26, 2016

fix #7233

@yenchenlin
Copy link
Contributor

Reviewers are often busy, please make sure CI has passed.

Base automatically changed from master to main January 22, 2021 10:49
@thomasjpfan
Copy link
Member

With scikit-learn 1.0, we use n_features_in_ to validate the number of features through the call to _check_X_y + _validate_data. Also coef_ is deprecated and removed in 1.1. Closing this PR since I do not think it is required anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:naive_bayes Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coef_ and intercept_ in MultinomialNB is pointless for binary classification
4 participants
@luoq @yenchenlin @thomasjpfan @amueller