BUG: for several datasets, download_if_missing keyword was ignored.
#7944
Conversation
|
LGTM but can you look why CIs are not happy? |
rgommers
force-pushed
the
dowload-if-missing
branch
from
08b8c82
to
d8d4b37
Compare
A combination of me being asleep and running the tests for the wrong version of |
| if e.errno == errno.ENOENT: | ||
| raise SkipTest("Covertype dataset can not be loaded.") | ||
| except IOError: | ||
| raise SkipTest("Covertype dataset can not be loaded.") |
There was a problem hiding this comment.
@agramfort I know it's an old code but why use a SkipTest rather than an assert_raise_message ?
There was a problem hiding this comment.
We don't know whether the call will succeed, right?
There was a problem hiding this comment.
Of course. Thanks for the clarification and sorry for the misunderstanding @amueller.
|
LGTM despite the |
|
regression test would be checking that we get an IOError if the file does not exist, right? Might be a bit overkill? Otherwise LGTM. |
|
LGTM |
|
uh that needs a whatsnew. Anyone wanna have a go? |
|
You mean a mention under "bug fixes" in |
|
indeed. Thanks :) |
Do what is promised in the docstring (raise an
IOError), ifdownload_if_missing=Falseand the dataset wasn't previously downloaded.