-
-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG + 1] Restructure the version info in the docs to fit in two lines. #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashil
changed the title
Restructure the version info in the docs to fit in two lines.
[MRG] Restructure the version info in the docs to fit in two lines.
Dec 19, 2016
fyi my version had a "v" before the version (inspired by numpy) but I'm happy either way. |
amueller
changed the title
[MRG] Restructure the version info in the docs to fit in two lines.
[MRG + 1] Restructure the version info in the docs to fit in two lines.
Dec 19, 2016
can you post a link to the html build please? |
Let's add a 'v'. I like the way you look for minute details :). I will post the build html once the new commit gets build. |
aashil
force-pushed
the
dev-fix-docs-version
branch
from
December 19, 2016 21:47
9d6aeeb
to
4a0d4f8
Compare
* This is done in order to fit the project name and version number in a single line. * This also ensures that we have enough space for a version number whose length exceeds current length.
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Addresses #7021
What does this implement/fix? Explain your changes.
Reformat the version info to fit within two lines.