Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] Restructure the version info in the docs to fit in two lines. #8084

Merged
merged 2 commits into from
Dec 20, 2016

Conversation

aashil
Copy link
Contributor

@aashil aashil commented Dec 19, 2016

Reference Issue

Addresses #7021

What does this implement/fix? Explain your changes.

Reformat the version info to fit within two lines.

@aashil aashil changed the title Restructure the version info in the docs to fit in two lines. [MRG] Restructure the version info in the docs to fit in two lines. Dec 19, 2016
@amueller
Copy link
Member

fyi my version had a "v" before the version (inspired by numpy) but I'm happy either way.
LGTM

@amueller amueller changed the title [MRG] Restructure the version info in the docs to fit in two lines. [MRG + 1] Restructure the version info in the docs to fit in two lines. Dec 19, 2016
@amueller
Copy link
Member

can you post a link to the html build please?

@aashil
Copy link
Contributor Author

aashil commented Dec 19, 2016

Let's add a 'v'. I like the way you look for minute details :). I will post the build html once the new commit gets build.

* This is done in order to fit the project name and version number in
  a single line.
* This also ensures that we have enough space for a version number whose
  length exceeds current length.
@aashil
Copy link
Contributor Author

aashil commented Dec 19, 2016

@jnothman jnothman merged commit a12e0ba into scikit-learn:master Dec 20, 2016
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants