Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Fixed output shape in doc for OrthogonalMatchingPursuit #8090

Closed
wants to merge 1 commit into from
Closed

[MRG] Fixed output shape in doc for OrthogonalMatchingPursuit #8090

wants to merge 1 commit into from

Conversation

SebastinSanty
Copy link
Contributor

Reference Issue

Fixes #8070

What does this implement/fix? Explain your changes.

coef_ shape changed in the doc from (n_features,) or (n_features, n_targets) to (n_features,) or (n_targets, n_features)

@jnothman
Copy link
Member

It's a bit yuck that orthogonal_mp_gram has a different ordering, but this is the right fix. Please also fix in OrthogonalMatchingPursuitCV

@jnothman
Copy link
Member

Thanks

@jnothman
Copy link
Member

Sorry, the correct fix was in #8091, now merged.

@jnothman jnothman closed this Dec 20, 2016
@SebastinSanty
Copy link
Contributor Author

Sorry, didn't notice the other PR coming up!

@jnothman
Copy link
Member

jnothman commented Dec 20, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect output shape in doc for OrthogonalMatchingPursuit
2 participants
@SebastinSanty @jnothman