Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add support to missing values in NMF #8474

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
+477 −93
Open

ENH add support to missing values in NMF #8474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b060ba0
add support to missing values in NMF
TomDLT Feb 27, 2017
2da40e1
Fix masked nonzero selection
TomDLT Oct 10, 2017
3b47aeb
Fix a bug in NMF.transform with NaN values in X
TomDLT Nov 13, 2017
b2f53b9
add ImputerNMF class
TomDLT Nov 13, 2017
65988e0
remove ImputerNMF
TomDLT Nov 15, 2017
c8e06b6
keep the same memory for np.dot(W, H)
TomDLT Nov 15, 2017
40ace5d
Fix incorrect ravel in non C-ordered array
TomDLT Nov 16, 2017
a838f94
Merge branch 'master' into nmf_missing
TomDLT Feb 8, 2018
c82092d
Merge branch 'master' into nmf_missing
TomDLT Aug 11, 2018
45c8912
Merge branch 'master' into nmf_missing
TomDLT Oct 2, 2018
52cadb7
DOC add accept_nan in docstring
TomDLT Oct 2, 2018
bc25003
Merge branch 'master' into nmf_missing
TomDLT Feb 21, 2019
7cdeb3a
Merge branch 'main' into nmf_missing
TomDLT Jan 5, 2023
3818534
extend to MinibatchNMF, apply black formatting
TomDLT Jan 5, 2023
28a9b0a
fix merging conflict
TomDLT Jan 5, 2023
c665aeb
fix black version
TomDLT Jan 5, 2023
0141c71
Merge branch 'main' into nmf_missing
TomDLT Jan 5, 2023
507f2d4
add changelog entry
TomDLT Jan 5, 2023
5bf5077
add allow_nan tag, add doc
TomDLT Jan 5, 2023
56ec4f5
fix allow_nan tag
TomDLT Jan 5, 2023
778f7be
fix check_array, simplify test diff
TomDLT Jan 5, 2023
bc91437
black
TomDLT Jan 5, 2023
ba84570
Merge branch 'main' into nmf_missing
TomDLT Jan 5, 2023
167985c
fix docstring, improve test
TomDLT Jan 5, 2023
7a859c7
black
TomDLT Jan 5, 2023
e52be53
rework test_nmf_imputation
TomDLT Jan 5, 2023
2663b8a
Merge branch 'main' into nmf_missing
TomDLT Jan 9, 2023
3b7a9c4
Merge branch 'main' into nmf_missing
TomDLT Mar 31, 2023
a3a418d
Merge branch 'main' into nmf_missing
TomDLT Apr 4, 2023
04e1d41
Merge branch 'main' into nmf_missing
TomDLT Apr 20, 2023
4269109
fix lint
TomDLT Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/whats_new/v1.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,11 @@ Changelog
:mod:`sklearn.decomposition`
............................

- |Feature| :class:`decomposition.NMF`(with `solver="mu"`) and
:class:`decomposition.MiniBatchNMF` now accept NaNs in the input data. The
loss function is then summing over the non-NaN elements of the input data.
:pr:`8474` by `Tom Dupre la Tour`_.

- |Enhancement| :class:`decomposition.DictionaryLearning` now accepts the parameter
`callback` for consistency with the function :func:`decomposition.dict_learning`.
:pr:`24871` by :user:`Omar Salman <OmarManzoor>`.
Expand Down