[MRG] Add Explanation of MSE vs Friedman MSE vs MAE criterion in Regression Tree Building #9367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warut-vijit
changed the title
|
Thanks for the contribution. A paragraph or so should be added to doc/module/tree.rst as well. |
|
The gist is that I want to add in a note regarding L1 minimizing the median into the docs. Maybe a full paragraph isn't necessary given the existing equations there. Thanks for the work. |
|
LGTM, thanks for the contribution. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
|
Will there be any explanations/math added on the official docs for Friedman MSE? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Example: Fixes #9355
What does this implement/fix? Explain your changes.
Modifies docs of DecisionTreeRegressor class to better explain criteria
MSE, Friedman MSE, MAE.
Any other comments?