Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Bring last code block in line with the image. #9488

Merged
merged 1 commit into from Aug 4, 2017
Merged

[MRG] Bring last code block in line with the image. #9488

merged 1 commit into from Aug 4, 2017

Conversation

julesjulian
Copy link
Contributor

Reference Issue

None.

What does this implement/fix? Explain your changes.

Last image on the tutorial page had three signals, the corresponding code only two. Also, imports were missing.

Any other comments?

The code is taken from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.

@amueller
Copy link
Member

amueller commented Aug 4, 2017

thanks

@amueller amueller merged commit 00358b1 into scikit-learn:master Aug 4, 2017
@julesjulian julesjulian deleted the patch-1 branch August 4, 2017 20:04
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 6, 2017
@julesjulian @jnothman
Bring last code block in line with the image. (scikit-learn#9488)
6ff8790 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@julesjulian @dmohns
Bring last code block in line with the image. (scikit-learn#9488)
c87351f 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@julesjulian @dmohns
Bring last code block in line with the image. (scikit-learn#9488)
4f24279 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Aug 12, 2017
@yarikoptic
Merge tag '0.19.0' into releases
445af38 
Release 0.19.0

* tag '0.19.0': (99 commits)
  DOC one more version issue in doc
  skip docstring tests because not useful to users and has some issues
  deprecation of n_components happened in 0.19 not 0.18 (scikit-learn#9527)
  sync whatsnew with master so I'm less confused
  DOC more navigation links
  DOC a note on data leakage and pipeline (scikit-learn#9510)
  DOC set release date to Friday
  DOC Update news and menu for 0.19 release
  DOC list of contributors to 0.19
  DOC Change release date to Thursday
  DOC Remove some whitespace from what's new
  Update what's new for recent changes
  Use base.is_classifier instead instead of isinstance (scikit-learn#9482)
  Fix safe_indexing with read-only indices (scikit-learn#9507)
  [MRG+1] add scorer based on explained_variance_score (scikit-learn#9259)
  fix wrong assert in test_validation (scikit-learn#9480)
  [MRG+1] FIX Add missing mixins to ClassifierChain (scikit-learn#9473)
  Bring last code block in line with the image. (scikit-learn#9488)
  FIX Pass sample_weight as kwargs in VotingClassifier (scikit-learn#9493)
  FIX Incorrent implementation of noise_variance_ in PCA._fit_truncated (scikit-learn#9108)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Aug 12, 2017
@yarikoptic
Merge branch 'releases' into dfsg
8f9558b 
* releases: (99 commits)
  DOC one more version issue in doc
  skip docstring tests because not useful to users and has some issues
  deprecation of n_components happened in 0.19 not 0.18 (scikit-learn#9527)
  sync whatsnew with master so I'm less confused
  DOC more navigation links
  DOC a note on data leakage and pipeline (scikit-learn#9510)
  DOC set release date to Friday
  DOC Update news and menu for 0.19 release
  DOC list of contributors to 0.19
  DOC Change release date to Thursday
  DOC Remove some whitespace from what's new
  Update what's new for recent changes
  Use base.is_classifier instead instead of isinstance (scikit-learn#9482)
  Fix safe_indexing with read-only indices (scikit-learn#9507)
  [MRG+1] add scorer based on explained_variance_score (scikit-learn#9259)
  fix wrong assert in test_validation (scikit-learn#9480)
  [MRG+1] FIX Add missing mixins to ClassifierChain (scikit-learn#9473)
  Bring last code block in line with the image. (scikit-learn#9488)
  FIX Pass sample_weight as kwargs in VotingClassifier (scikit-learn#9493)
  FIX Incorrent implementation of noise_variance_ in PCA._fit_truncated (scikit-learn#9108)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Aug 12, 2017
@yarikoptic
Merge branch 'dfsg' into debian
c9e232e 
* dfsg: (99 commits)
  DOC one more version issue in doc
  skip docstring tests because not useful to users and has some issues
  deprecation of n_components happened in 0.19 not 0.18 (scikit-learn#9527)
  sync whatsnew with master so I'm less confused
  DOC more navigation links
  DOC a note on data leakage and pipeline (scikit-learn#9510)
  DOC set release date to Friday
  DOC Update news and menu for 0.19 release
  DOC list of contributors to 0.19
  DOC Change release date to Thursday
  DOC Remove some whitespace from what's new
  Update what's new for recent changes
  Use base.is_classifier instead instead of isinstance (scikit-learn#9482)
  Fix safe_indexing with read-only indices (scikit-learn#9507)
  [MRG+1] add scorer based on explained_variance_score (scikit-learn#9259)
  fix wrong assert in test_validation (scikit-learn#9480)
  [MRG+1] FIX Add missing mixins to ClassifierChain (scikit-learn#9473)
  Bring last code block in line with the image. (scikit-learn#9488)
  FIX Pass sample_weight as kwargs in VotingClassifier (scikit-learn#9493)
  FIX Incorrent implementation of noise_variance_ in PCA._fit_truncated (scikit-learn#9108)
  ...
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@julesjulian @paulha
Bring last code block in line with the image. (scikit-learn#9488)
1fbbeac 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@julesjulian @AishwaryaRK
Bring last code block in line with the image. (scikit-learn#9488)
f52e4c5 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@julesjulian @maskani-moh
Bring last code block in line with the image. (scikit-learn#9488)
b0c1de2 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@julesjulian
Bring last code block in line with the image. (scikit-learn#9488)
0870753 
Code from http://scikit-learn.org/stable/auto_examples/decomposition/plot_ica_blind_source_separation.html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julesjulian @amueller