Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Add Normalized Discounted Cumulative Gain #9951

Merged
merged 67 commits into from Aug 13, 2019
Merged

[MRG+1] Add Normalized Discounted Cumulative Gain #9951

merged 67 commits into from Aug 13, 2019

Commits on Oct 18, 2017

  1. add DCG and NDCG

    @jeromedockes
    jeromedockes committed Oct 18, 2017
    Copy the full SHA
    4f70065 View commit details
    Browse the repository at this point in the history

  2. add wikipedia links for ndcg

    @jeromedockes
    jeromedockes committed Oct 18, 2017
    Copy the full SHA
    0e06a80 View commit details
    Browse the repository at this point in the history

  3. missing blank line

    @jeromedockes
    jeromedockes committed Oct 18, 2017
    Copy the full SHA
    3542fcd View commit details
    Browse the repository at this point in the history

  4. fix ndcg test

    @jeromedockes
    jeromedockes committed Oct 18, 2017
    Copy the full SHA
    7e5190e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. undo unrelated change to metrics/__init__.py

    @jeromedockes
    jeromedockes committed Oct 19, 2017
    Copy the full SHA
    f78f8cb View commit details
    Browse the repository at this point in the history

  2. improve dcg and ndcg docstrings

    @jeromedockes
    jeromedockes committed Oct 19, 2017
    Copy the full SHA
    776ed36 View commit details
    Browse the repository at this point in the history

  3. use check_array and check_consistent_length

    @jeromedockes
    jeromedockes committed Oct 19, 2017
    Copy the full SHA
    17ca372 View commit details
    Browse the repository at this point in the history

  4. add dcg and ndcg to test_common thresholded metrics

    @jeromedockes
    jeromedockes committed Oct 19, 2017
    Copy the full SHA
    dbf3826 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2017

  1. backport np.unique with return_counts in sklearn.utils.fixes

    @johny-c
    johny-c committed Oct 22, 2017
    Copy the full SHA
    f9d741f View commit details
    Browse the repository at this point in the history

  2. add a test function in utils.tests.test_fixes.py

    @johny-c
    johny-c committed Oct 22, 2017
    Copy the full SHA
    140a682 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. change link to correct numpy commit

    @johny-c
    johny-c committed Oct 24, 2017
    Copy the full SHA
    ad71190 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2017

  1. unused import

    @jeromedockes
    jeromedockes committed Nov 6, 2017
    Copy the full SHA
    c3552f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2017

  1. remove references in private functions' docstrings

    @jeromedockes
    jeromedockes committed Nov 19, 2017
    Copy the full SHA
    ca48505 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. add test dcg and ndcg on toy examples

    @jeromedockes
    jeromedockes committed Nov 21, 2017
    Copy the full SHA
    560ccd3 View commit details
    Browse the repository at this point in the history

  2. add examples to ndcg_score and dcg_score docstrings

    @jeromedockes
    jeromedockes committed Nov 21, 2017
    Copy the full SHA
    d68ee1a View commit details
    Browse the repository at this point in the history

  3. fix ndcg_score doctests

    @jeromedockes
    jeromedockes committed Nov 21, 2017
    Copy the full SHA
    aa4bd9c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2018

  1. average ties in ndcg

    @jeromedockes
    jeromedockes committed Jan 3, 2018
    Copy the full SHA
    e6c2c01 View commit details
    Browse the repository at this point in the history

  2. faster dcg tie averaging

    @jeromedockes
    jeromedockes committed Jan 3, 2018
    Copy the full SHA
    1bc867e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Merge branch 'master' into add_ndcg

    @jeromedockes
    jeromedockes committed Mar 5, 2018
    Copy the full SHA
    f395ba0 View commit details
    Browse the repository at this point in the history

  2. add test dcg ties

    @jeromedockes
    jeromedockes committed Mar 5, 2018
    Copy the full SHA
    15bbb4f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'johny_c/backport-np-unique' into add_ndcg

    @jeromedockes
    jeromedockes committed Mar 5, 2018
    Copy the full SHA
    934969e View commit details
    Browse the repository at this point in the history

  4. use backport for unique with return_counts

    @jeromedockes
    jeromedockes committed Mar 5, 2018
    Copy the full SHA
    cfc2309 View commit details
    Browse the repository at this point in the history

  5. test ndcg invariant if order preserved

    @jeromedockes
    jeromedockes committed Mar 5, 2018
    Copy the full SHA
    5d0b9a6 View commit details
    Browse the repository at this point in the history

  6. check translation invariant

    @jeromedockes
    jeromedockes committed Mar 5, 2018
    Copy the full SHA
    abd579f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. add reference for tied ndcg

    @jeromedockes
    jeromedockes committed Mar 7, 2018
    Copy the full SHA
    2bb30b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. add narrative doc for ndcg

    @jeromedockes
    jeromedockes committed Mar 8, 2018
    Copy the full SHA
    a9d8368 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Merge branch 'master' into add_ndcg

    @jeromedockes
    jeromedockes committed Apr 23, 2018
    Copy the full SHA
    fb0b667 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2018

  1. improve ndcg documentation

    @jeromedockes
    jeromedockes committed May 7, 2018
    Copy the full SHA
    2c996e9 View commit details
    Browse the repository at this point in the history

  2. plain assert instead of assert_true in ndcg tests

    @jeromedockes
    jeromedockes committed May 7, 2018
    Copy the full SHA
    09cf1b5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into add_ndcg

    @jeromedockes
    jeromedockes committed May 7, 2018
    Copy the full SHA
    df1df69 View commit details
    Browse the repository at this point in the history

  4. move checks to public dcg/ndcg functions

    @jeromedockes
    jeromedockes committed May 7, 2018
    Copy the full SHA
    4517f06 View commit details
    Browse the repository at this point in the history

  5. fix key error in metrics/test_common.py

    @jeromedockes
    jeromedockes committed May 7, 2018
    Copy the full SHA
    97677ee View commit details
    Browse the repository at this point in the history

  6. check target type in ndcg (not only dcg)

    @jeromedockes
    jeromedockes committed May 7, 2018
    Copy the full SHA
    f908fef View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. add ignore_ties option to dcg and ndcg for performance

    @jeromedockes
    jeromedockes committed May 17, 2018
    Copy the full SHA
    981783c View commit details
    Browse the repository at this point in the history

  2. improve examples in dcg and ndcg docstrings

    @jeromedockes
    jeromedockes committed May 17, 2018
    Copy the full SHA
    af81310 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed May 17, 2018
    Copy the full SHA
    5bf100a View commit details
    Browse the repository at this point in the history

  4. docstring details

    @jeromedockes
    jeromedockes committed May 17, 2018
    Copy the full SHA
    6059a7c View commit details
    Browse the repository at this point in the history

  5. unused variable

    @jeromedockes
    jeromedockes committed May 17, 2018
    Copy the full SHA
    c545c63 View commit details
    Browse the repository at this point in the history

  6. add ndcg to whatsnew

    @jeromedockes
    jeromedockes committed May 17, 2018
    Copy the full SHA
    d865cea View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. Merge branch 'master' into add_ndcg

    @jeromedockes
    jeromedockes committed May 19, 2018
    Copy the full SHA
    75f4515 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Merge branch 'master' into add_ndcg

    @jeromedockes
    jeromedockes committed Jun 7, 2018
    Copy the full SHA
    9ba639b View commit details
    Browse the repository at this point in the history

  2. more details about DCG in documentation

    @jeromedockes
    jeromedockes committed Jun 7, 2018
    Copy the full SHA
    66f63a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed Feb 14, 2019
    Copy the full SHA
    371ab30 View commit details
    Browse the repository at this point in the history

  2. flake8 ignore unused import in fixes

    @jeromedockes
    jeromedockes committed Feb 14, 2019
    Copy the full SHA
    fc36f39 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. address scikit-learn#9951 (comment)

    @jeromedockes
    jeromedockes committed Feb 15, 2019
    Copy the full SHA
    c894380 View commit details
    Browse the repository at this point in the history

  2. remove examples with perfect prediction from dcg docstrings

    @jeromedockes
    jeromedockes committed Feb 15, 2019
    Copy the full SHA
    988546b View commit details
    Browse the repository at this point in the history

  3. more details in ndcg docs + comparison with ranking loss

    @jeromedockes
    jeromedockes committed Feb 15, 2019
    Copy the full SHA
    306cb88 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. remove np.unique from utils.fixes

    @jeromedockes
    jeromedockes committed Mar 19, 2019
    Copy the full SHA
    1feef33 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed Mar 19, 2019
    Copy the full SHA
    5d3c5a6 View commit details
    Browse the repository at this point in the history

  3. remove tests made obsolete by numpy version bump

    @jeromedockes
    jeromedockes committed Mar 19, 2019
    Copy the full SHA
    ea0f545 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed Apr 24, 2019
    Copy the full SHA
    b396471 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed Jun 5, 2019
    Copy the full SHA
    e77eb64 View commit details
    Browse the repository at this point in the history

  2. update whatsnew

    @jeromedockes
    jeromedockes committed Jun 5, 2019
    Copy the full SHA
    b763abe View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed Jul 16, 2019
    Copy the full SHA
    c7e2c19 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Merge remote-tracking branch 'upstream/master' into add_ndcg

    @jeromedockes
    jeromedockes committed Jul 19, 2019
    Copy the full SHA
    81ac36c View commit details
    Browse the repository at this point in the history

  2. address comments on doc

    @jeromedockes
    jeromedockes committed Jul 19, 2019
    Copy the full SHA
    ba2c07c View commit details
    Browse the repository at this point in the history

  3. revert change unrelated to NDCG

    @jeromedockes
    jeromedockes committed Jul 19, 2019
    Copy the full SHA
    96233cb View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. add docstring for _tie_averaged_dcg

    @jeromedockes
    jeromedockes committed Jul 22, 2019
    Copy the full SHA
    67f4dc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. log_basis -> log_base

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    00c2d2a View commit details
    Browse the repository at this point in the history

  2. performance -> efficiency

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    450065c View commit details
    Browse the repository at this point in the history

  3. comment about ignoring ties when computing normalization in ndcg

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    11574ce View commit details
    Browse the repository at this point in the history

  4. np.zeros -> np.empty

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    ccc0875 View commit details
    Browse the repository at this point in the history

  5. parametrize test_ndcg_toy_examples with ignore_ties

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    3d4f2cc View commit details
    Browse the repository at this point in the history

  6. check same results with k and ignore_ties in the absence of ties

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    cb8a6b4 View commit details
    Browse the repository at this point in the history

  7. pep8

    @jeromedockes
    jeromedockes committed Jul 25, 2019
    Copy the full SHA
    3d6d286 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Merge branch 'master' into add_ndcg

    @glemaitre
    glemaitre committed Aug 12, 2019
    Copy the full SHA
    24413d8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into add_ndcg

    @glemaitre
    glemaitre committed Aug 12, 2019
    Copy the full SHA
    0cafb21 View commit details
    Browse the repository at this point in the history