Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling the super class in epr.py is not using the parameters #176

Closed
paulogonc opened this issue Apr 10, 2021 · 1 comment
Closed

Calling the super class in epr.py is not using the parameters #176

paulogonc opened this issue Apr 10, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@paulogonc
Copy link

paulogonc commented Apr 10, 2021

Hi,

I was wondering by playing with your code, why I'm not seeing any differences by playing with other values of the parameter min_wait_time_minutes which is initialized with 20. So I took a look in your code and I found out, that all inherited classes in epr.py does not take into account the passed parameters like here in the SpatialEPR class:

def __init__(self, name='Density EPR model', rho=0.6, gamma=0.21, beta=0.8, tau=17, min_wait_time_minutes=20):
        super().__init__() # <-- missing here the values which needs to be passed to the super class
        self._name = name

If I change the code like this:

def __init__(self, name='Spatial EPR model', rho=0.6, gamma=0.21, beta=0.8, tau=17, min_wait_time_minutes=20):
        super().__init__(name=name, rho=rho, gamma=gamma, beta=beta, tau=tau, min_wait_time_minutes=min_wait_time_minutes)

the new values for the parameter min_wait_time_minutes will be used.

Maybe you can consider that. Thanks and best regards Paulo

@jonpappalord jonpappalord added the bug Something isn't working label Apr 10, 2021
@jonpappalord jonpappalord added this to the v.1.2.3 milestone Apr 10, 2021
FilippoSimini added a commit that referenced this issue May 31, 2021
@FilippoSimini
Copy link
Member

Fixed in v.1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants