Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Expose base_estimator in GBTQuantiles #26

Closed
betatim opened this issue Mar 29, 2016 · 3 comments
Closed

Expose base_estimator in GBTQuantiles #26

betatim opened this issue Mar 29, 2016 · 3 comments
Labels
Easy Enhancement

Comments

@betatim
Copy link
Member

betatim commented Mar 29, 2016

Comment by @glouppe in #9:

Would be good to expose the base_estimator in this newly introduced class. Default params of GradientBoostingRegressor are very likely to give poor results.
@glouppe
Copy link
Member

glouppe commented Mar 29, 2016

Also, not fan of GBT (sorry for being picky). Let's be explicit instead. What about GradientBoostingQuantileRegressor? or GradientBoostingQuantiler?

@betatim
Copy link
Member Author

betatim commented Mar 29, 2016

No worries, I also don't like the name but couldn't come up with something good. GradientBoostingQuantileRegressor is my favourite so far.

@betatim betatim mentioned this issue Mar 29, 2016
Merged
@betatim betatim reopened this Mar 29, 2016
@betatim
Copy link
Member Author

betatim commented Mar 29, 2016

Reopened as we still need to expose base_estimator

@betatim betatim mentioned this issue Jun 16, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Easy Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glouppe @betatim @MechCoder