Change all occurences of npy to np #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Network
Plotting
IO
Media
Calibration
Time
TransmissionLines
labels
jhillairet
approved these changes
May 3, 2024
|
Yeah I'm not sure. All the tests pass so hm... |
|
ruff reports some errors when executing locally, that's why the test fails. However it's confusing that the errors are not shown properly. I'll check in the next few days locally. |
|
can you try to merge master back in? |
|
Seems like those changes addressed the linting issues! (Just waiting for the rtd task to finish) |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #1040 , convert all instances of npy to np