change ifft to fft in gate frequency domain calculation #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #390 , changed
kernel=fft.fftshift(fft.ifft(fft.ifftshift(gate, axes=0), axis=0))
to
kernel2=fft.ifftshift(fft.fft(fft.fftshift(gate, axes=0), axis=0))
While it produces a different mathematical result (for example due to the different iFFT/FFT normalization, see fft doc), the final result is the same as only the normalized magnitude is kept after: