Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Open, SeriesImpedance and ShuntAdmittance classmethods to Circuit #529

Merged
merged 3 commits into from Oct 6, 2021
Merged

Add Open, SeriesImpedance and ShuntAdmittance classmethods to Circuit #529

merged 3 commits into from Oct 6, 2021

Conversation

jhillairet
Copy link
Member

  • Added convenient ways to create 2-ports open, serie-impedance and shunt-admittance using Circuit.
  • Added some specific tests
  • Use SerieImpedance in an example

@github-actions github-actions bot added Circuit Documentation Request/Improvement of the documentation labels Sep 24, 2021
@jhillairet jhillairet added Improvements Improvements of existing feature New Feature A new feature in progress labels Sep 24, 2021
luar123
luar123 reviewed Oct 6, 2021
View reviewed changes
skrf/circuit.py Outdated Show resolved Hide resolved
@jhillairet jhillairet mentioned this pull request Oct 6, 2021
Closed
@jhillairet jhillairet merged commit 25bee1d into scikit-rf:master Oct 6, 2021
@jhillairet jhillairet mentioned this pull request Nov 6, 2021
Merged
@jhillairet jhillairet deleted the dev/circuit branch January 22, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luar123 luar123 luar123 left review comments

Assignees
No one assigned
Labels
Circuit Documentation Request/Improvement of the documentation Improvements Improvements of existing feature New Feature A new feature in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhillairet @luar123