Fix for #662 and other minor corrections #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhillairet
approved these changes
May 16, 2022
skrf/media/media.py
Outdated
| r""" | ||
| Shunted capacitor. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| C : number, array-like | ||
| Capacitance in Farads. | ||
| \*args,\*\*kwargs : arguments, keyword arguments | ||
| \*\*kwargs : arguments, keyword arguments | ||
| passed to func:`delay_open` |
There was a problem hiding this comment.
Suggested change
| passed to func:`delay_open` | |
| passed to func:`capacitor` |
There was a problem hiding this comment.
Thanks! I found and corrected quite a few more of those things
jhillairet
approved these changes
May 19, 2022
|
OK to merge? |
|
Yes, that should be all. Can I give it a shot and merge it myself? |
|
sure! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts array-like parameters in various
Mediamethods to NumPy arrays.In addition, I made a few corrections to the formatting and removed incorrect
*args