Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Circuit Ports with attribute instead of name #671

Merged
merged 1 commit into from
May 22, 2022
Merged

Mark Circuit Ports with attribute instead of name #671

merged 1 commit into from
May 22, 2022

Conversation

Ttl
Copy link
Collaborator

@Ttl Ttl commented May 21, 2022

Fixes #670

@github-actions github-actions bot added Circuit Documentation Request/Improvement of the documentation labels May 21, 2022
@Ttl Ttl mentioned this pull request May 21, 2022
Closed
jhillairet
jhillairet approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

As only the number associated to the portname is useful now, I wonder if changing the API for Port(frequency, port_index) would make more sense. TBD, eventually in a future PR.

@jhillairet jhillairet added the fix Bug Fix label May 21, 2022
@jhillairet
Copy link
Member

OK for merging

@Ttl Ttl merged commit 3c73c3c into scikit-rf:master May 22, 2022
@jhillairet jhillairet mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

Assignees
No one assigned
Labels
Circuit Documentation Request/Improvement of the documentation fix Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circuits should not rely only on the network name to detect a port
2 participants
@Ttl @jhillairet