-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes in IEEE P370 doc #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, the notebook is more clear and follow more closely the standard with this notation!
There is however a pitfall:
The svg are clear and neat and following the standard but the Matlab code ported to skrf
, h is flipping FIX-2 in such a way DUT = FIX-1.inv ** FIX-DUT-FIX ** FIX-2.inv
which is not correct according to the standard labelling.
I wonder if we should make FIX-2 compliant to the standard and svg so the equation would become FIX-1.inv ** FIX-DUT-FIX ** FIX-2.flipped().inv
I think it should, to match the standard labelling proposal. |
@mhuser , shall I merge this one as you are working on the notebook too? |
@jhillairet I think yes, I will be soon finishing the first proposal so hopefully, it will not last very long with the non-flipped numbering. |
rendered page: https://scikit-rf--694.org.readthedocs.build/en/694/examples/networktheory/IEEEP370%20Deembedding.html