Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes in IEEE P370 doc #694

Merged
merged 3 commits into from
Jun 11, 2022
Merged

Conversation

jhillairet
Copy link
Member

@jhillairet jhillairet commented Jun 9, 2022

  • added some additional content in the introduction and some figures (@mhuser could you check it's OK?)
  • use coherent terminology for labelling fixtures and DUT (following the one proposed in the standard)
  • fix sphinx rendering of the lists

rendered page: https://scikit-rf--694.org.readthedocs.build/en/694/examples/networktheory/IEEEP370%20Deembedding.html

@jhillairet jhillairet added Documentation Request/Improvement of the documentation Calibration labels Jun 9, 2022
@jhillairet jhillairet requested a review from mhuser June 9, 2022 14:10
Copy link
Collaborator

@mhuser mhuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the notebook is more clear and follow more closely the standard with this notation!

There is however a pitfall:

The svg are clear and neat and following the standard but the Matlab code ported to skrf, h is flipping FIX-2 in such a way DUT = FIX-1.inv ** FIX-DUT-FIX ** FIX-2.inv which is not correct according to the standard labelling.

I wonder if we should make FIX-2 compliant to the standard and svg so the equation would become FIX-1.inv ** FIX-DUT-FIX ** FIX-2.flipped().inv

@jhillairet
Copy link
Member Author

I wonder if we should make FIX-2 compliant to the standard and svg so the equation would become FIX-1.inv ** FIX-DUT-FIX ** FIX-2.flipped().inv

I think it should, to match the standard labelling proposal.

@jhillairet
Copy link
Member Author

@mhuser , shall I merge this one as you are working on the notebook too?

@mhuser
Copy link
Collaborator

mhuser commented Jun 11, 2022

shall I merge this one as you are working on the notebook too?

@jhillairet I think yes, I will be soon finishing the first proposal so hopefully, it will not last very long with the non-flipped numbering.

@jhillairet jhillairet merged commit b0a2002 into scikit-rf:master Jun 11, 2022
@jhillairet jhillairet deleted the doc/IEEEP370 branch June 18, 2022 08:58
@jhillairet jhillairet mentioned this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Request/Improvement of the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants