IEEEP370 Flip FIX-2 and minor improvements #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update docstring to IEEEP370 recommanded numbering scheme
github-actions
bot
added
the
Documentation
in the IEEEP repo, IEEEP370 NZC has the ability to use `s2z` and `z2s` instead ifft. According to the commit that added this functionnality, it is intended to use with very short fixture that have not enough point in time domain, e.g. a single point. In this case the impedance midpoint computation cannot give the expected results.
|
Should be review ready 😄 |
jhillairet
approved these changes
Jun 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make IEEEP370 deembedding method use the labelling and numbering scheme recommended by the IEEEP370 standard.
The deembedding equation should be like this:
DUT = FIX-1.inv ** FIX-DUT-FIX ** FIX-2.flipped().invAlso add minor improvements: