Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector Fitting: Minor updates #706

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Vector Fitting: Minor updates #706

merged 4 commits into from
Jun 16, 2022

Conversation

Vinc0110
Copy link
Collaborator

Fixes a few minor issues:

  • extending VectorFitting.plot() to plot either S, Z, or Y parameters of the (optional) base network in VectorFitting.network
  • adding a docstring for VectorFitting.network to have it listed in the docs
  • addressing the new UserWarnings in case of non-passive fits of passive networks in the example notebooks

@github-actions github-actions bot added Documentation Request/Improvement of the documentation VectorFitting labels Jun 13, 2022
@jhillairet jhillairet added this to the v0.23.0 milestone Jun 14, 2022
@Vinc0110 Vinc0110 merged commit bd39949 into scikit-rf:master Jun 16, 2022
@Vinc0110 Vinc0110 deleted the vf_updates branch June 16, 2022 04:28
@jhillairet jhillairet mentioned this pull request Jun 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

Assignees
No one assigned
Labels
Documentation Request/Improvement of the documentation VectorFitting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vinc0110 @jhillairet