Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fft_window when specified and not window #802

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Use fft_window when specified and not window #802

merged 2 commits into from
Nov 24, 2022

Conversation

FranzForstmayr
Copy link
Collaborator

Currently we check if fft_window parameter is not None, but we use window parameter to get the window.
This PR uses the fft_window as argument for get_window.

@github-actions github-actions bot added the Time label Nov 21, 2022
Vinc0110
Vinc0110 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@Vinc0110 Vinc0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was not my brightest moment. Good catch!

By the way, I propose to set the default to fft_window='cosine' while you are at it. It seems to work best in my tests.

@FranzForstmayr FranzForstmayr merged commit 9a2c0fd into scikit-rf:master Nov 24, 2022
@jhillairet jhillairet mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

@Vinc0110 Vinc0110 Vinc0110 approved these changes

Assignees
No one assigned
Labels
Time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FranzForstmayr @jhillairet @Vinc0110