Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #808

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Misc fixes #808

merged 4 commits into from
Dec 6, 2022

Conversation

eendebakpt
Copy link
Contributor

  • Add description to skrf.calibration.Normalization calibration
  • Fix docstring of UnknownThru, remove unused variables
  • Use np.asarray in conversions (this prevents unnecessary copying of data)
  • Fix docstring of Network.__div__

Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you !

@jhillairet jhillairet added Documentation Request/Improvement of the documentation Improvements Improvements of existing feature labels Dec 5, 2022
@jhillairet
Copy link
Member

@eendebakpt do you foreseen to make additional changes, or could I merge your PR?

@eendebakpt
Copy link
Contributor Author

@eendebakpt do you foreseen to make additional changes, or could I merge your PR?

Up to you. I will be using scikit-rf in the near future and might add some more changes either to this PR or a new PR.

@jhillairet
Copy link
Member

OK. So I'll merge for now. You're welcome to open new PRs of course.

@jhillairet jhillairet merged commit 0f2fbc6 into scikit-rf:master Dec 6, 2022
@eendebakpt eendebakpt deleted the misc_fixes branch December 6, 2022 13:54
@jhillairet jhillairet mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calibration Documentation Request/Improvement of the documentation Improvements Improvements of existing feature Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants