Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-port calibration #818

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Multi-port calibration #818

merged 4 commits into from
Jan 15, 2023

Conversation

Ttl
Copy link
Collaborator

@Ttl Ttl commented Dec 28, 2022

Adds code for calibrating multi-port S-parameter measurements using any two-port calibration method. Internally it works very similarly to measuring multi-port network with two-port VNA example.

@github-actions github-actions bot added Calibration Documentation Request/Improvement of the documentation Network labels Dec 28, 2022
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice. Sorry for the delay in reviewing. Only a detail concerning a class docstring.

skrf/calibration/calibration.py Outdated Show resolved Hide resolved
@Ttl Ttl merged commit 34576e9 into scikit-rf:master Jan 15, 2023
@Ttl Ttl mentioned this pull request Jan 16, 2023
@arsenovic
Copy link
Member

thanks! nice addition!

@jhillairet jhillairet mentioned this pull request Feb 9, 2023
@jhillairet jhillairet mentioned this pull request Apr 3, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calibration Documentation Request/Improvement of the documentation Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants