Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name argument to two_port_reflect #829

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Add name argument to two_port_reflect #829

merged 4 commits into from
Feb 8, 2023

Conversation

eendebakpt
Copy link
Contributor

No description provided.

jhillairet
jhillairet approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Eventually, could you add an associated test?

jhillairet
jhillairet approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Vinc0110 Vinc0110 merged commit 65ce252 into scikit-rf:master Feb 8, 2023
@eendebakpt eendebakpt deleted the two_port_reflect branch February 8, 2023 20:51
@jhillairet jhillairet mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

@Vinc0110 Vinc0110 Vinc0110 approved these changes

Assignees
No one assigned
Labels
Network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eendebakpt @jhillairet @Vinc0110