Overlap dut and dummy networks in deembedding #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericwrice, do you plan to extend the tests soon, or can I merge? |
|
@jhillairet, I think you're good to merge. I'd be happy to extend the tests later if that's desirable. |
keikawa
reviewed
Feb 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the TODO comments in each of the deembedding classes to overlap the dut and dummy networks if their frequencies are not equal. Also adds an overlap_multi() convenience function in network to handle n number of overlap operations. The raised errors have been changed to runtime warnings. The tests probably need to be expanded to include networks with different frequencies.