Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically load version from __init__.py #837

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Dynamically load version from __init__.py #837

merged 2 commits into from
Feb 9, 2023

Conversation

Vinc0110
Copy link
Collaborator

@Vinc0110 Vinc0110 commented Feb 8, 2023

Changes pyproject.toml so it dynamically loads the version number for a build from skrf/__init__.py. That way, the version number only has to be defined once (in __init__.py).

https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

jhillairet
jhillairet approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nice addition, to be tested very soon for the next release!

@jhillairet jhillairet merged commit 458f276 into scikit-rf:master Feb 9, 2023
@jhillairet jhillairet mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

Assignees
No one assigned
Labels
Continuous integration and Code Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vinc0110 @jhillairet