Add test for input networks of OnePort calibration #844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for a
OnePort
calibration by accident the standards are entered as[two_port_reflect(short, short), two_port_reflect(open, open), two_port_reflect(load, load)]
the calibration succeeds, but it cannot be applied (error:LinAlgError: Singular matrix
).Also expressions like
calibration.coefs_ntwks['reflection tracking'].plot_s_db()
fail.This PR adds a check on the input networks and a test.