Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing rtol for sweep type tests #847

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

Vinc0110
Copy link
Collaborator

In issue #846, the logarithmic sweep type was not detected correctly due to minor deviations from the ideal curve (< 1.5%). This PR increases the relative tolerance in np.allclose() to 5%.

logspacing

@jhillairet jhillairet merged commit da8ef58 into scikit-rf:master Feb 14, 2023
@jhillairet jhillairet mentioned this pull request Feb 14, 2023
@Vinc0110 Vinc0110 deleted the sweeptype_rtol branch February 18, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants