-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot attributes #848
Plot attributes #848
Conversation
|
We should really ask our self, if we need that much methods on a class like NetworkSet. This PR should not make any functional difference to any user, but we really need to tighten the API in the future. |
There are the same changes in the PR #852, could say essentially what/where are the difference? I'm a bit lost...
This is probably too much you're right, but it's hard to say what users are really using or not.... |
what about this one for the next release ? |
There are some docstring which need some more work. I think we should wait for the next one. |
@FranzForstmayr could you look to the conflicts and make a brief summary of the purpose of the the changes ? |
I'm ready to merge if ok |
This PR tries to get rid of the code in
scikit-rf/skrf/plotting.py
Line 900 in 26243ff
Due to less code parsing the initialization time should be reduced, as the method itself is now parsed only once (
plot_attrribute
), for the individual plotting methods likeplot_s_re
,plot_s_db
and so on, the method is called with different parameters.For all the autogenerated methods a new docstring is created. There's no way to check the correctness of the plot, however we can see if a exception gets thrown.