Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create variables to modify nudge_eig thresholds #859

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Create variables to modify nudge_eig thresholds #859

merged 1 commit into from
Mar 29, 2023

Conversation

jhillairet
Copy link
Member

Fix #741
Create new variables in the constants part that can be tuned to modify nudge_eig thresholds

@jhillairet jhillairet added the Feature Request Wished Feature label Mar 23, 2023
@jhillairet
Copy link
Member Author

@vishak-venkatraman, could you test this PR and let me know if by changing the following variables:
rf.constants.EIG_COND or rf.constants.EIG_MIN it solves your issue?

@jhillairet jhillairet merged commit 30a1d9c into scikit-rf:master Mar 29, 2023
@jhillairet jhillairet deleted the dev/nudge_eig_constants branch April 1, 2023 18:04
@jhillairet jhillairet mentioned this pull request Apr 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinc0110 Vinc0110 Vinc0110 approved these changes

Assignees
No one assigned
Labels
Feature Request Wished Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nudge_eig function is causing wrong conversion of S->Z
2 participants
@jhillairet @Vinc0110