Fix reading/writing HFSS Touchstone files using the 'power' S-param definition #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804
s_def
parameter is not explicitly passed (ies_def=None
), the assumption ofpower
is delayed after have read the touchstone data.s_def
is set to the default HFSS setting only ifs_def
has not been passed explicitly. Otherwise if uses the passeds_def
The following will work:
where
S_DEF_HFSS_DEFAULT
is a new constant, currently defined as 'traveling' (while i'm still not sure about the real meaning of "Generalized" in HFSS...)s_def
check/warning before writing a file. So now, importing a 'power' Touchstone file (passings_def='power'
when reading) and writing the Touchstone file should lead to same results.