Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Network.copy also copy params dict #887

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Make Network.copy also copy params dict #887

merged 2 commits into from
Apr 10, 2023

Conversation

cafeclimber
Copy link
Contributor

Currently, Network.copy() does not copy params which was extremely confusing in my case. copy should be a full deep copy. This PR makes that the case.

@cafeclimber
Copy link
Contributor Author

Addresses #886

jhillairet
jhillairet approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, good catch

@jhillairet jhillairet merged commit efd8a72 into scikit-rf:master Apr 10, 2023
10 checks passed
@jhillairet jhillairet mentioned this pull request May 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

Assignees
No one assigned
Labels
Network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cafeclimber @jhillairet