Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit] ruff #892

Merged
merged 21 commits into from
May 4, 2023
Merged

[pre-commit] ruff #892

merged 21 commits into from
May 4, 2023

Conversation

jhillairet
Copy link
Member

Adding ruff to the pre-commit configuration and fixes the found issues for each rules

@github-actions github-actions bot added Calibration Documentation Request/Improvement of the documentation IO Media Network labels Apr 12, 2023
@eendebakpt eendebakpt mentioned this pull request Apr 16, 2023
Merged
@jhillairet jhillairet marked this pull request as ready for review April 26, 2023 17:48
@jhillairet
rule E501 : line length violation
894dc1c 
- use 120 long lines instead of the default88
- correct some strings to make it pass.
@jhillairet
Rule E712 : true-false-comparison
1228661 
Comparison to True should be cond is True or if cond:
@jhillairet
document ignored fules
b14aa43
@jhillairet
Copy link
Member Author

Tests are passing but there is problem with coveralls for some reasons (cf lemurheavy/coveralls-public#1708).

Most of rules are now checked, except:

  • F403: undefined-local-with-import-star
  • F405: undefined-local-with-import-star-usage
  • F841: unused-variable
  • E741: ambiguous-variable-name

which require more work.

mhuser
mhuser approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@mhuser mhuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Lot of syntax ehancement done here.

@jhillairet jhillairet merged commit 186202e into scikit-rf:master May 4, 2023
11 checks passed
@jhillairet jhillairet mentioned this pull request May 6, 2023
Merged
@jhillairet jhillairet deleted the dev/pre-commit-ruff branch July 28, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuser mhuser mhuser approved these changes

Assignees
No one assigned
Labels
Calibration Continuous integration and Code Quality Documentation Request/Improvement of the documentation IO Media Network Plotting Time TransmissionLines VectorFitting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhillairet @mhuser