Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot.yml #898

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Create dependabot.yml #898

merged 2 commits into from
Apr 30, 2023

Conversation

jhillairet
Copy link
Member

Dependabot to automatically keep the dependencies and packages used in your repository updated to the latest version

Dependabot to automatically keep the dependencies and packages used in your repository updated to the latest version
@FranzForstmayr
Copy link
Collaborator

I'm not really sure how this should work.

For example we use numpy >= 1.21, the current version is 1.24. Will dependabot automatically increase the minimum required numpy if allowed by the other requirements? If that's the case I'm against, as we would disallow users of older numpy versions to use skrf without any technical reason.

I'm perfectly fine to update a package if needed from our side.

@jhillairet
Copy link
Member Author

For example we use numpy >= 1.21, the current version is 1.24. Will dependabot automatically increase the minimum required numpy if allowed by the other requirements? If that's the case I'm against, as we would disallow users of older numpy versions to use skrf without any technical reason.

Yes, I agree with you. We are making a Python package, not a webapp in javascript, so we don't require to be on the cutting edge of the required packages.

There is a version-strategy: increase-if-necessary option I should include in the config file, which increases the version requirement only when required by the new version. To be tested.

Add a versioning strategy option to relax the depencies versionning
@jhillairet jhillairet merged commit 4351a5d into master Apr 30, 2023
18 checks passed
@jhillairet jhillairet mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants