Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug that touchstone files containing noise could not be cropped. #913

Merged
merged 1 commit into from
May 25, 2023
Merged

Fixed the bug that touchstone files containing noise could not be cropped. #913

merged 1 commit into from
May 25, 2023

Conversation

Asachoo
Copy link
Contributor

@Asachoo Asachoo commented May 24, 2023

Because self.noise_freq is an object of type skr.frequency.Frequency , but the npy.copy function should handle objects of type np.ndarray.
So self.noise_freq needs to use deepcopy for deep copy instead of npy.copy.

@jhillairet jhillairet added the fix Bug Fix label May 24, 2023
@jhillairet jhillairet merged commit afeaa34 into scikit-rf:master May 25, 2023
11 checks passed
@jhillairet
Copy link
Member

Thank you and welcome as a contributor!

@jhillairet jhillairet mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants