Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy1.25 #922

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Numpy1.25 #922

merged 4 commits into from
Jun 23, 2023

Conversation

FranzForstmayr
Copy link
Collaborator

Try to make skrf compatible to numpy 1.25

@Ttl
Copy link
Collaborator

Ttl commented Jun 21, 2023

All the [0] indexing in qfactor looks suspicious. If they are actually one element vectors then it would make sense to instead make them scalars when they are created which I think is at the end of _initial_fit function.

@FranzForstmayr
Copy link
Collaborator Author

I'm also not really a fan of this solution...
I will think of your approach the next days.

@FranzForstmayr
Copy link
Collaborator Author

Will close #921

@FranzForstmayr FranzForstmayr merged commit 097a64f into scikit-rf:master Jun 23, 2023
11 checks passed
@jhillairet jhillairet mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ttl Ttl Ttl approved these changes

Assignees
No one assigned
Labels
Calibration Media
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FranzForstmayr @Ttl