Allow to pass a callable fucnction as window argument #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could we get this into #924 ? :) |
jhillairet
approved these changes
Jun 28, 2023
Co-authored-by: Julien Hillairet <julien.hillairet@gmail.com>
jhillairet
approved these changes
Jun 28, 2023
|
The function is currently not in the public API, do we need this for this case? |
|
Eventually. You can add the function name in the docstring at the top of time.py |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to define more customized windows and not just the window functions from scipy.