Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calibration.ipynb #930

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update Calibration.ipynb #930

merged 1 commit into from
Jul 10, 2023

Conversation

mjpelmear
Copy link
Contributor

Apparently the function name changed at some point.

Apparently the function name changed at some point.
@github-actions github-actions bot added the Documentation Request/Improvement of the documentation label Jul 8, 2023
@FranzForstmayr
Copy link
Collaborator

Good Catch!
Usually the notebooks should get executed after each PR, but obviously this one wasnt.
We should find the reason why this notebook is exclude from testing.

@jhillairet jhillairet added the fix Bug Fix label Jul 10, 2023
@Ttl
Copy link
Collaborator

Ttl commented Jul 10, 2023

It looks like all of the cells in this notebook are markdown and there is no executable code. This should be rewritten so that the code is actually executed.

@jhillairet
Copy link
Member

jhillairet commented Jul 10, 2023

Yes indeed, that's because it's a generic explanation, not a specific example. But eventually it can be transformer to a practical example.

Thank you @mjpelmear !

@jhillairet jhillairet merged commit c6e85af into scikit-rf:master Jul 10, 2023
11 checks passed
@jhillairet jhillairet mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Request/Improvement of the documentation fix Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants