-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports the creation of capacitors and inductors with Q factor. #933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this proposal @Asachoo . I have a coupled of remarks and questions, please have a look.
Co-authored-by: Julien Hillairet <julien.hillairet@gmail.com>
…ent with the s-parameter generated by ADS default parameters.
In the commit 17b902f, the network created by the inductor_q method is consistent with the network created by ADS using the default "Proportional to freq" mode.
|
OK, great. The use of the ref frequency is consistent between both methods, seems more logical. Could you add some dedicated tests for both methods ? (adding and checking agasint your reference S-param from ADS like you did) |
Related test items have been added. |
Co-authored-by: Julien Hillairet <julien.hillairet@gmail.com>
OK with me, thank you @Asachoo. Let's wait a bit if other have comments. |
Thank you @Asachoo |
Supports the creation of capacitive and inductive devices with Q factors.
The s-parameters of the created device are consistent with the results of the default parameters of INDQ and CAPQ created by ADS, that is, the Q-factor proportional to frequency (f) of the inductor and the Q-factor of the capacitor are constant.
https://edadocs.software.keysight.com/display/genesys2010/CAPQ
https://edadocs.software.keysight.com/display/genesys2010/INDQ