Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports the creation of capacitors and inductors with Q factor. #933

Merged
merged 8 commits into from
Jul 28, 2023

Conversation

Asachoo
Copy link
Contributor

@Asachoo Asachoo commented Jul 18, 2023

Supports the creation of capacitive and inductive devices with Q factors.
The s-parameters of the created device are consistent with the results of the default parameters of INDQ and CAPQ created by ADS, that is, the Q-factor proportional to frequency (f) of the inductor and the Q-factor of the capacitor are constant.

https://edadocs.software.keysight.com/display/genesys2010/CAPQ
https://edadocs.software.keysight.com/display/genesys2010/INDQ

@github-actions github-actions bot added the Media label Jul 18, 2023
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this proposal @Asachoo . I have a coupled of remarks and questions, please have a look.

skrf/media/media.py Outdated Show resolved Hide resolved
skrf/media/media.py Outdated Show resolved Hide resolved
skrf/media/media.py Show resolved Hide resolved
skrf/media/media.py Show resolved Hide resolved
skrf/media/media.py Outdated Show resolved Hide resolved
Asachoo and others added 3 commits July 18, 2023 16:00
Co-authored-by: Julien Hillairet <julien.hillairet@gmail.com>
…ent with the s-parameter generated by ADS default parameters.
@Asachoo
Copy link
Contributor Author

Asachoo commented Jul 20, 2023

In the commit 17b902f, the network created by the inductor_q method is consistent with the network created by ADS using the default "Proportional to freq" mode.

>>> import skrf as rf
>>> import numpy as np
>>> std_ntwk = rf.Network('L1Q30F20.s2p')
>>> line = rf.media.DefinedGammaZ0(std_ntwk.frequency)
>>> tst_ntwk = line.inductor_q(L=1e-9, q_factor=30, f_0=2.0e9)
>>> np.allclose(std_ntwk.s, tst_ntwk.s)
True

L1Q30F20.zip

@jhillairet
Copy link
Member

In the commit 17b902f, the network created by the inductor_q method is consistent with the network created by ADS using the default "Proportional to freq" mode.

OK, great. The use of the ref frequency is consistent between both methods, seems more logical.

Could you add some dedicated tests for both methods ? (adding and checking agasint your reference S-param from ADS like you did)

@jhillairet jhillairet added the New Feature A new feature in progress label Jul 21, 2023
@Asachoo
Copy link
Contributor Author

Asachoo commented Jul 21, 2023

In the commit 17b902f, the network created by the inductor_q method is consistent with the network created by ADS using the default "Proportional to freq" mode.

OK, great. The use of the ref frequency is consistent between both methods, seems more logical.

Could you add some dedicated tests for both methods ? (adding and checking agasint your reference S-param from ADS like you did)

Related test items have been added.

skrf/media/media.py Outdated Show resolved Hide resolved
skrf/media/media.py Outdated Show resolved Hide resolved
Co-authored-by: Julien Hillairet <julien.hillairet@gmail.com>
@jhillairet
Copy link
Member

OK with me, thank you @Asachoo. Let's wait a bit if other have comments.

@jhillairet jhillairet merged commit dec6d02 into scikit-rf:master Jul 28, 2023
11 checks passed
@jhillairet
Copy link
Member

Thank you @Asachoo

@jhillairet jhillairet mentioned this pull request Sep 1, 2023
@Asachoo Asachoo deleted the INDQ_and_CAPQ branch May 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media New Feature A new feature in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants