Force PNA to use expected format for SNP data #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solid fix! Thanks! (Also glad to hear the update is working for you!) |
jhillairet
approved these changes
Nov 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_snp_network()in the PNA virtual instrument expects the data to be returned in Real/Imaginary format, but the instrument isn't necessarily configured to do so. This pull request alters the behavior to save the initial SNP format, change it to Real/Imaginary, then restore the original after pulling the SNP data.You can verify that this matters by manually setting the SNP data type to one of the other values ("MA" or "DB") before calling
get_snp_network()on the master branch. e.g.,instr.write("MMEM:STOR:TRACE:FORM:SNP MA").This was tested on a Keysight P9374A, but I use similar code on PNAs (where I can't test this change directly).