Deal with deficient Z or Y matrices in y2z() and z2y() #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhillairet
added
New Feature
|
OK. Should a warning be emitted as discussed in #977 ? |
|
It should not be necessary if the detour option works, or what do you think @zolabar? |
@Vinc0110 thank you for consulting. I personally (as for now) would appreciate a warning, because Z or Y may not exist because of physical reasons. If we still manage to get them the user should know that they may not represent the phyisics he expects. |
|
Done. Thank you! |
Thank you! |
jhillairet
approved these changes
Nov 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #977.
Instead of giving up in case of deficient matrices, we can still try the detour via
s2z(y2s(y))ors2y(z2s(z)).