Define circuit name at initialization

[rragona]

I suggest to have the possibility to define the name of a circuit network during the circuit initialization, as argument of the constructor, e.g., cir = rf.Circuit(cnx, name = 'circuit').

To use a network inside a circuit connection list requires the network to have a name. Indeed in the __init__ of circuit.py:

# check if all networks have a name  
        for cnx in self.connections:  
            for (ntw, _) in cnx:  
                if not self._is_named(ntw):  
                    raise AttributeError('All Networks must have a name. Faulty network:', ntw)

Currently, one is forced to use a variable to store the circuit network, and then specify a name, e.g.:

cir = rf.Circuit(cnx)
ntw = cir.network
ntw.name = "circuit"

I find the suggested option more convenient, and readable, especially when nesting several circuits inside other circuits.

[jhillairet]

Hi Riccardo,

Thanks for the PR! I have only a minor modification suggested for the docstring.

[jhillairet]

Thank you @rragona and welcome as a new contributor :) !