Make SOLT class inherit run method from TwelveTermModel to allow arbitrary thrus #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ttl
reviewed
Dec 19, 2023
| ] | ||
|
|
||
| measured = [ self.measure(k) for k in actuals] | ||
| measured = [ self.measure(k) for k in ideals] |
There was a problem hiding this comment.
This test previously tested that without specifying an ideal thru a flush thru is assumed. There isn't now a test for it and it's now the only difference between SOLT and TwelveTerm. I think this could be reverted. In MultiportSOLTTest it should be possible to replace thru withwg.line though.
There was a problem hiding this comment.
done.
SOLTTest now tests again a flush thru if no ideal thru is given. MultiportSOLTTest tests against non-flush thru mismatchlinemismatch
… is given, make MultiportSOLTTest to test against non-flush thru
Ttl
approved these changes
Dec 20, 2023
jhillairet
approved these changes
Dec 21, 2023
|
Thank you @floschl ! |
|
You are welcome! Keep your great work up! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR from this PR #983
To date, SOLT class does only accept flush thrus. This a modification to make SOLT class inherit run method from TwelveTermModel to allow arbitrary thrus, as discussed in #983 .
Docstrings were also adjusted.