Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max_dim to maxdim #6

Closed
sauln opened this issue Apr 17, 2019 · 2 comments
Closed

Change max_dim to maxdim #6

sauln opened this issue Apr 17, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sauln
Copy link
Member

sauln commented Apr 17, 2019

Ripser.py uses the keyword maxdim while cechmate uses max_dim. We should standardize this across both projects. Since Ripser.py has a userbase already, I vote we change cechmate.

@sauln sauln added bug Something isn't working good first issue Good for newcomers labels Apr 17, 2019
@ctralie
Copy link
Member

ctralie commented Apr 17, 2019 via email

@ctralie
Copy link
Member

ctralie commented Jun 11, 2019

As a related issue, cech and alpha don't have max_dim in their constructor; only base does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants